OP#421 final

.vscode/settings.json

@@ -2,10 +2,14 @@
     "cSpell.words": [
         "argstring",
         "checkmodule",
+        "confdroid",
         "dont",
         "getsebool",
+        "Hotspots",
         "metachars",
+        "NRPE",
         "procs",
+        "puppetlabs",
         "refreshonly",
         "semodule",
         "setsebool",

README.md

@@ -44,7 +44,7 @@ NRPE allows monitoring tools like NAGIOS or ICINGA to connect to clients for mon
 - manage selinux rule exceptions (optional)
 - manage NRPE service
 
-> Note: The value for the `nagios_server` variable is derived from a global parameter set in Foreman (`nagios_server`), because the paremeter is used across multiple modules. You need to set that manually in Foreman under "Global Parameters". Same for `nagios_source`, the value for the firewall source, which should point to the source IP or source range for the nagios server querying NRPE.
+> Note: The value for the `nagios_source` variable is derived from a global parameter set in Foreman (`nagios_source`), because the parameter is used across multiple modules. You need to set that manually in Foreman under "Global Parameters".
 
 ## Repo Documentation
 
@@ -117,7 +117,7 @@ All files and directories are configured with correct selinux context. If selinu
 - Puppet Lint
   - excluded tests:
     - `--no-variable_scope-check`: not applicable as we are inheriting parameters from params class. the lint check does not distinguish between facts and inherited parameters.
-    - `--no-top_scope_facts`: iptables does not recognise otherwise
+    - `--no-top_scope_facts`: iptables does not recognize otherwise
 - Puppet Parser
 - ERB Template Parser
 - Sonar Quality Gate

manifests/params.pp

@@ -130,7 +130,6 @@ class confdroid_nrpe::params (
   $domain                   = $facts['networking']['domain']
   $os_name                  = $facts['os']['name']
   $os_release               = $facts['os']['release']['major']
-  $nagios_server            = $::nagios_server
   $nagios_source            = $::nagios_source
 
 # service

templates/nrpe_cfg.erb

@@ -20,7 +20,7 @@ listen_queue_size=<%= @ne_listen_queue_size %>
 nrpe_user=<%= @ne_user %>
 nrpe_group=<%= @ne_user %>
 
-allowed_hosts=127.0.0.1,::1,<%= @nagios_server %>
+allowed_hosts=127.0.0.1,::1,<%= @nagios_source %>
 dont_blame_nrpe=<%= @ne_dont_blame_nrpe %>
 allow_bash_command_substitution=<%= @ne_allow_bash_cmd_subst %>