confdroid/confdroid_ssh
1
0
Fork 0
Code Issues Projects Wiki Activity

adjust everything for compliance with puppet-lint

Browse Source
This commit is contained in:
Arne Teuke
2025-05-16 11:58:00 +02:00
parent ac7699e75d
commit 84977adbc5
3 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Jenkinsfile vendored
View File

@@ -51,16 +51,9 @@ pipeline {
stage('puppet-lint') { stage('puppet-lint') {
steps { steps {
sh '''find . -iname *.pp -exec /usr/local/rvm/gems/ruby-2.5.0/wrappers/puppet-lint \\ sh '''/usr/local/bin/puppet-lint . \\
--no-class_inherits_from_params_class-check \\ --no-variable_scope-check \\
--no-variable_scope-check \\
--no-80chars-check \\
--no-arrow_alignment-check \\
--no-autoloader_layout-check \\
--no-140chars-check \\
--log-format "%{path}:%{line}:%{check}:%{KIND}:%{message}" {} \\;
''' '''
recordIssues aggregatingResults: true, tool: puppetLint()
} }
} }

6
README.md
View File

@@ -33,15 +33,9 @@ ALmost every puppet setup is done in very custom ways, and hence the way the mod
* Puppet Lint * Puppet Lint
* excluded tests: * excluded tests:
* `--no-class_inherits_from_params_class-check`:relevant only to non-supported outdated puppet versions
* `--no-variable_scope-check`: not applicable as we are inheriting parameters from params class. the lint check does not distinguish between facts and inherited parameters. * `--no-variable_scope-check`: not applicable as we are inheriting parameters from params class. the lint check does not distinguish between facts and inherited parameters.
* `--no-80chars-check`: it is not always possible to stay within 80 characters, although typically only occurring on the parameter vault `params.pp`.
* `--no-arrow_alignment-check`: this check leads to actually not having am easily readable arrow alignment, as this checks `per block`, not per class.
* Puppet Parser * Puppet Parser
* ERB Template Parser * ERB Template Parser
* Test for unwanted UTF8 files in the Puppet code (see tests/UTF_Files)
* Markdown-lint
* Spellcheck
* Sonar Quality Gate * Sonar Quality Gate
## Contact Us ## Contact Us

4
manifests/params.pp
View File

@@ -2,8 +2,8 @@
# Module name: ssh_cd # Module name: ssh_cd
# Author: Arne Teuke (arne_teuke@confdroid.com) # Author: Arne Teuke (arne_teuke@confdroid.com)
# @summary Class contains all class parameters for ssh_cd # @summary Class contains all class parameters for ssh_cd
# @param [array] reqpackages packages to install # @param [Array] reqpackages packages to install
# @param [string] pkg_ensure version to install: 'present' or 'latest' # @param [String] pkg_ensure version to install: 'present' or 'latest'
############################################################################## ##############################################################################
class ssh_cd::params ( class ssh_cd::params (