diff --git a/Jenkinsfile b/Jenkinsfile index d53470c..d8f198b 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -51,16 +51,9 @@ pipeline { stage('puppet-lint') { steps { - sh '''find . -iname *.pp -exec /usr/local/rvm/gems/ruby-2.5.0/wrappers/puppet-lint \\ - --no-class_inherits_from_params_class-check \\ - --no-variable_scope-check \\ - --no-80chars-check \\ - --no-arrow_alignment-check \\ - --no-autoloader_layout-check \\ - --no-140chars-check \\ - --log-format "%{path}:%{line}:%{check}:%{KIND}:%{message}" {} \\; + sh '''/usr/local/bin/puppet-lint . \\ + --no-variable_scope-check \\ ''' - recordIssues aggregatingResults: true, tool: puppetLint() } } diff --git a/README.md b/README.md index d07c2a3..8a03a40 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Readme -[![Build Status](https://pipelines.confdroid.com/buildStatus/icon?job=ssh_cd)](https://pipelines.confdroid.com/job/ssh_cd/)| +[![Build Status](https://pipelines.confdroid.com/buildStatus/icon?job=ssh_cd)](https://pipelines.confdroid.com/job/ssh_cd/)| [[_TOC_]] @@ -33,15 +33,9 @@ ALmost every puppet setup is done in very custom ways, and hence the way the mod * Puppet Lint * excluded tests: - * `--no-class_inherits_from_params_class-check`:relevant only to non-supported outdated puppet versions * `--no-variable_scope-check`: not applicable as we are inheriting parameters from params class. the lint check does not distinguish between facts and inherited parameters. - * `--no-80chars-check`: it is not always possible to stay within 80 characters, although typically only occurring on the parameter vault `params.pp`. - * `--no-arrow_alignment-check`: this check leads to actually not having am easily readable arrow alignment, as this checks `per block`, not per class. * Puppet Parser * ERB Template Parser -* Test for unwanted UTF8 files in the Puppet code (see tests/UTF_Files) -* Markdown-lint -* Spellcheck * Sonar Quality Gate ## Contact Us diff --git a/manifests/params.pp b/manifests/params.pp index 673ba0a..0f0020c 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -2,8 +2,8 @@ # Module name: ssh_cd # Author: Arne Teuke (arne_teuke@confdroid.com) # @summary Class contains all class parameters for ssh_cd -# @param [array] reqpackages packages to install -# @param [string] pkg_ensure version to install: 'present' or 'latest' +# @param [Array] reqpackages packages to install +# @param [String] pkg_ensure version to install: 'present' or 'latest' ############################################################################## class ssh_cd::params (