From f39c1e36b56e589e70c85bcbe19be23848bc88f7 Mon Sep 17 00:00:00 2001 From: Arne Teuke Date: Sun, 30 Jul 2017 19:06:33 +0100 Subject: [PATCH 1/2] changed default illegal characters --- README.md | 6 ++++++ manifests/params.pp | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index fb30a83..904d222 100644 --- a/README.md +++ b/README.md @@ -111,6 +111,12 @@ All files and directories are configured with correct selinux context. If selinu ### Known Problems * SSL/TLS support: Version 3 of NRPE supposedly has support for SSL/ TLs. However, at the time of writing this module, this seems to be buggy, as I was unable to start the NRPE service as soon as the `ssl_cert_file` line was uncommented in teh configuration file, despite having valid certs in the right position on the node. This happened when installing manually, not through this Puppet module. For that reason I included the `$ne_enable_ssl` boolean parameter, which is set to `false` by default, hence disabling SSL/TLS options until this has been fixed upstream, or a valid workaround has been found. Setting this option to `true` will include all SSL / TLS settings. +### Troubleshooting +* `CHECH_NRPE: Unable to read output`: Nagios sudo access also needs Selinux to allow this. Default settings in this module take care for both through `$ne_allow_sudo` and `$ne_include_selinux`. +* `CHECK_NRPE: Receive header underflow - only 0 bytes received (4 expected): This is down to the new illegal meta characters feature via `nasty_metachars`. + + + ### Support * OS: CentOS 6, 7 * Puppet 3.x diff --git a/manifests/params.pp b/manifests/params.pp index b87607e..2d230e1 100644 --- a/manifests/params.pp +++ b/manifests/params.pp @@ -78,7 +78,7 @@ # 0x10 (16) = Log if client has a certificate # 0x20 (32) = Log details of client's certificate if it has one # -1 or 0xff or 0x2f = All of the above -# @param [string] ne_nasty_metachars list of characters that cannot +# @param [array] ne_nasty_metachars list of characters that cannot # be passed to the NRPE daemon. # @param [string] ne_include_file include definitions from an external # config file. @@ -137,7 +137,7 @@ $ne_ssl_cert_file = "/etc/pki/tls/certs/${::fqdn}.crt.pem", $ne_ssl_privatekey_file = "/etc/pki/tls/private/${::fqdn}.key.pem", $ne_ssl_client_certs = '2', $ne_ssl_logging = '0x00', -$ne_nasty_metachars = '"|`&><\'\\[]{};\r\n\"', +$ne_nasty_metachars = ["|`&><[]{};\n\'"], $ne_include_file = '', # nrpe.conf From edc943caf47ae87bee9b1a1422560c321af4b493 Mon Sep 17 00:00:00 2001 From: Jenkins Server Date: Sun, 30 Jul 2017 20:06:28 +0200 Subject: [PATCH 2/2] recommit for updates in build 58 --- CHANGELOG.md | 10 ++++++++++ doc/_index.html | 2 +- doc/file.README.html | 14 +++++++++++++- doc/index.html | 14 +++++++++++++- doc/puppet_classes/cd_nrpe.html | 2 +- ...d_nrpe_3A_3Acommands_3A_3Adefinition_rules.html | 2 +- .../cd_nrpe_3A_3Afirewall_3A_3Aiptables.html | 2 +- .../cd_nrpe_3A_3Amain_3A_3Aconfig.html | 2 +- .../cd_nrpe_3A_3Amain_3A_3Adirs.html | 2 +- .../cd_nrpe_3A_3Amain_3A_3Afiles.html | 2 +- .../cd_nrpe_3A_3Amain_3A_3Ainstall.html | 2 +- .../cd_nrpe_3A_3Amain_3A_3Aservice.html | 2 +- .../cd_nrpe_3A_3Amain_3A_3Auser.html | 2 +- doc/puppet_classes/cd_nrpe_3A_3Aparams.html | 8 ++++---- .../cd_nrpe_3A_3Aselinux_3A_3Aconfig.html | 2 +- .../cd_nrpe_3A_3Acommands_3A_3Adefinitions.html | 2 +- doc/top-level-namespace.html | 2 +- 17 files changed, 53 insertions(+), 19 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 58be893..3cee149 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,16 @@ Changelog of Git Changelog.

No issue

+0e95b79c6ee5bf6 Arne Teuke 2017-07-30 17:02:06 +

+

re-enabled sudo setting

+ +

+a07e88ee0c6f279 Jenkins Server 2017-07-30 17:02:01 +

+

recommit for updates in build 57

+ +

27d1b70d6198a0b Arne Teuke 2017-07-30 16:58:43

added selinux boolean

diff --git a/doc/_index.html b/doc/_index.html index a49355d..78654bf 100644 --- a/doc/_index.html +++ b/doc/_index.html @@ -176,7 +176,7 @@ diff --git a/doc/file.README.html b/doc/file.README.html index 8ef9749..3facd3c 100644 --- a/doc/file.README.html +++ b/doc/file.README.html @@ -277,6 +277,18 @@ has been fixed upstream, or a valid workaround has been found. Setting this option to true will include all SSL / TLS settings.

+

Troubleshooting

+ +

Support

+

Troubleshooting

+ +

Support