From dfc113675aad9777f3e6cab7dbde2df7caf95bfd Mon Sep 17 00:00:00 2001
From: Arne Teuke <arne_teuke@confdroid.com>
Date: Fri, 19 Oct 2018 18:14:32 +0200
Subject: [PATCH] updates README

---
 Gemfile     |  8 ++++----
 Jenkinsfile | 37 ++++++++++---------------------------
 README.md   |  5 ++---
 3 files changed, 16 insertions(+), 34 deletions(-)

diff --git a/Gemfile b/Gemfile
index 628327e..807ab6f 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,13 +1,13 @@
 source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
-puppetversion = ENV.key?('PUPPET_VERSION') ? ENV['PUPPET_VERSION'] : ['>= 3.3']
+puppetversion = ENV.key?('PUPPET_VERSION') ? ENV['PUPPET_VERSION'] : ['<= 5.5.6']
 gem 'metadata-json-lint'
 gem 'puppet', puppetversion
 gem 'puppetlabs_spec_helper', '>= 1.0.0'
-gem 'puppet-lint', '>= 1.0.0'
-gem 'facter', '>= 1.7.0'
+gem 'puppet-lint'
+gem 'facter'
 gem 'rspec-puppet'
-gem 'puppet-strings'
+#gem 'puppet-strings'
 gem 'rake'
 gem 'semantic_puppet'
 gem 'rgen'
diff --git a/Jenkinsfile b/Jenkinsfile
index b47b2b1..73c6752 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -28,9 +28,9 @@ pipeline {
             --no-class_inherits_from_params_class-check \\
             --no-variable_scope-check \\
             --no-80chars-check \\
-            --no-140chars-check \\
             --no-arrow_alignment-check \\
             --no-autoloader_layout-check \\
+            --no-140chars-check \\
             --log-format "%{path}:%{line}:%{check}:%{KIND}:%{message}" {} \\;'''
           }
         }
@@ -38,7 +38,7 @@ pipeline {
       stage('puppet parser test') {
         steps {
           sh '''for file in $(find . -iname \'*.pp\'); do
-            puppet parser validate --color false --render-as s --modulepath=modules $file || exit 1;
+            /opt/puppetlabs/bin/puppet parser validate --color false --render-as s --modulepath=modules $file || exit 1;
             done;'''
           }
         }
@@ -59,18 +59,16 @@ pipeline {
 
       stage('update repo structure') {
         steps {
-          sh '''if [ test -f REPOSTRUCTURE.md ]; then
-                rm -Rf REPOSTRUCTURE.md
-                fi
+          sh '''rm -Rf REPOSTRUCTURE.md
                 echo "$(tree --dirsfirst --charset=ascii .)" > REPOSTRUCTURE.md'''
         }
       }
 
-      stage('create Puppet documention') {
-        steps {
-          sh 'puppet strings'
-        }
-      }
+//      stage('create Puppet documention') {
+//        steps {
+//          sh 'puppet strings'
+//        }
+//      }
 
       stage('create changelog') {
         steps{
@@ -97,7 +95,7 @@ Changelog of Git Changelog.
 
 
    {{#commits}}
-<a href="https://gitlab.confdroid.com/12WW1160/git-changelog-lib/commit/{{hash}}">{{hash}}</a> {{authorName}} <i>{{commitTime}}</i>
+<a href="https://gitlab.puppetsoft.com/12WW1160/git-changelog-lib/commit/{{hash}}">{{hash}}</a> {{authorName}} <i>{{commitTime}}</i>
 <p>
 <h3>{{{messageTitle}}}</h3>
 
@@ -130,7 +128,7 @@ Changelog of Git Changelog.
   {{/hasIssue}}
 
    {{#commits}}
-[https://gitlab.confdroid.com/12WW1160/git-changelog-lib/commit/{{hash}} {{hash}}] {{authorName}} {{commitTime}}
+[https://gitlab.puppetsoft.com/12WW1160/git-changelog-lib/commit/{{hash}} {{hash}}] {{authorName}} {{commitTime}}
 
 \'\'\'{{{messageTitle}}}\'\'\'
 
@@ -184,27 +182,12 @@ Changelog of Git Changelog.
         }
       }
 
-      stage('check for UTF-8 files') {
-        steps {
-          sh '''if [ ! -d tests ]; then
-                mkdir tests
-                fi
-                if [ -f tests/UTF_Files ]; then
-                rm -Rf tests/UTF_Files
-                fi
-                echo "$(find . -type f -exec file {} \\;)" > FileList
-                echo  "$(grep -v ASCII FileList | grep -v git)" > tests/UTF_Files'''
-        }
-      }
-
       stage('show diff') {
         steps {
           sh 'git diff'
         }
       }
 
-
-
       stage('recommit changes to repo') {
         steps {
           sshagent(['edd05eb6-26b5-4c7b-a5cc-ea2ab899f4fa']) {
diff --git a/README.md b/README.md
index 52c7df0..85d655a 100644
--- a/README.md
+++ b/README.md
@@ -151,9 +151,8 @@ So far this module works through the usage of NRPE, which by default is enabled.
 ### Manage Additional Resources
 
 ### Known Problems
-* Collected resources import ordering problem:  The module might try to import collected facts before nagios is even installed. 
-* SELINUX modules: it appears that sealerts are different accross systems.  it might be typically easier  to work through sealerts manually. 
-
+* Collected resources import ordering problem:  The module might try to import collected facts before nagios is even installed.
+* SELINUX modules: it appears that sealerts are different accross systems.  it might be typically easier  to work through sealerts manually.
 
 ### Support
 * OS: CentOS 6, 7