From 59b78b2194448e237197cf2847bf8f2f2d053870 Mon Sep 17 00:00:00 2001
From: 12ww1160 <12ww1160@confdroid.com>
Date: Sun, 1 Mar 2026 17:17:00 +0100
Subject: [PATCH] OP#436 add members

---
 manifests/nagios/objects/add_contactgroups.pp       | 3 +++
 manifests/nagios/objects/add_contactgroups_rules.pp | 6 +++---
 manifests/nagios/objects/add_hostgroup_rules.pp     | 5 ++---
 manifests/params.pp                                 | 6 ------
 templates/nagios/contactgroups_cfg_rule.erb         | 1 +
 5 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/manifests/nagios/objects/add_contactgroups.pp b/manifests/nagios/objects/add_contactgroups.pp
index f0e2493..ca17b52 100644
--- a/manifests/nagios/objects/add_contactgroups.pp
+++ b/manifests/nagios/objects/add_contactgroups.pp
@@ -9,11 +9,14 @@
 #   contact group
 # @param [string] ng_contactgroup_register Specify whether the contact group
 #   should be registered in Nagios.
+# @param [string] ng_contactgroup_members Specify the members of the contact 
+#   group.
 ################################################################################
 define confdroid_nagios::nagios::objects::add_contactgroups (
 
   Optional[String] $ng_contactgroup_name     = undef,
   Optional[String] $ng_contactgroup_alias    = undef,
+  String $ng_contactgroup_members            = 'admins',
   String $ng_contactgroup_register           = '1',
 
 ) {
diff --git a/manifests/nagios/objects/add_contactgroups_rules.pp b/manifests/nagios/objects/add_contactgroups_rules.pp
index 646df65..2d9e7dc 100644
--- a/manifests/nagios/objects/add_contactgroups_rules.pp
+++ b/manifests/nagios/objects/add_contactgroups_rules.pp
@@ -39,9 +39,9 @@ class confdroid_nagios::nagios::objects::add_contactgroups_rules (
 
     # add main contact group through define via parameters
     confdroid_nagios::nagios::objects::add_contactgroups { $ng_contactgroup_name:
-      ng_contactgroup_name   => $ng_contactgroup_name,
-      ng_contactgroup_alias  => $ng_contactgroup_alias,
-      ng_contactgroup_ensure => $ng_contactgroup_ensure,
+      ng_contactgroup_name    => $ng_contactgroup_name,
+      ng_contactgroup_alias   => $ng_contactgroup_alias,
+      ng_contactgroup_members => $ng_contactgroup_members,
     }
   }
 }
diff --git a/manifests/nagios/objects/add_hostgroup_rules.pp b/manifests/nagios/objects/add_hostgroup_rules.pp
index d50dd5e..e1f3851 100644
--- a/manifests/nagios/objects/add_hostgroup_rules.pp
+++ b/manifests/nagios/objects/add_hostgroup_rules.pp
@@ -38,9 +38,8 @@ class confdroid_nagios::nagios::objects::add_hostgroup_rules (
 
     # add hostgroup rules through defines and parameters
     confdroid_nagios::nagios::objects::add_hostgroups { $ng_hostgroup_name:
-      ng_hostgroup_name   => $ng_hostgroup_name,
-      ng_hostgroup_alias  => $ng_hostgroup_alias,
-      ng_hostgroup_ensure => $ng_hostgroup_ensure,
+      ng_hostgroup_name  => $ng_hostgroup_name,
+      ng_hostgroup_alias => $ng_hostgroup_alias,
     }
   }
 }
diff --git a/manifests/params.pp b/manifests/params.pp
index be63e17..15d3ca4 100644
--- a/manifests/params.pp
+++ b/manifests/params.pp
@@ -77,8 +77,6 @@
 #   Default is 'admins'.
 # @param [String] ng_contactgroup_alias The alias of the default contact group.
 #   Default is 'Nagios Administrators'.
-# @param [String] ng_contactgroup_ensure The ensure value for the default
-#   contact group. Default is 'present'.
 # @param [String] ng_contact_name The name of the default contact. Default is
 #   'nagiosadmin'.
 # @param [String] ng_contact_alias The alias of the default contact. Default is
@@ -91,8 +89,6 @@
 #   is 'linux-servers'.
 # @param [String] ng_hostgroup_alias The alias of the default host group. Default
 #   is 'Linux Servers'.
-# @param [String] ng_hostgroup_ensure The ensure value for the default host group
-#   Default is 'present'.
 # @param [String] ng_max_check_attempts The maximum number of check attempts 
 #   before a host or service is considered down. Default is '10'.
 # @param [Boolean] ng_enable_swap_check Whether to enable the check_swap 
@@ -119,7 +115,6 @@ class confdroid_nagios::params (
 # contact groups
   String $ng_contactgroup_name       = 'admins',
   String $ng_contactgroup_alias      = 'Nagios Administrators',
-  String $ng_contactgroup_ensure     = 'present',
 
 # contacts
   String $ng_contact_name            = 'nagiosadmin',
@@ -130,7 +125,6 @@ class confdroid_nagios::params (
 # hostgroups
   String $ng_hostgroup_name         = 'linux-servers',
   String $ng_hostgroup_alias        = 'Linux Servers',
-  String $ng_hostgroup_ensure       = 'present',
 
 # nagios.cfg
   String $ng_log_file               = '/var/log/nagios/nagios.log',
diff --git a/templates/nagios/contactgroups_cfg_rule.erb b/templates/nagios/contactgroups_cfg_rule.erb
index a3c7d4c..6836537 100644
--- a/templates/nagios/contactgroups_cfg_rule.erb
+++ b/templates/nagios/contactgroups_cfg_rule.erb
@@ -2,5 +2,6 @@
 define contactgroup {
   contactgroup_name   <%= @ng_contactgroup_name %>
   alias               <%= @ng_contactgroup_alias %>
+  members             <%= @ng_contactgroup_members %>
   register            <%= @ng_contactgroup_register %>
   }