OP#672 update Readme with new feature

README.md

@@ -44,6 +44,7 @@ CONFIGURATION
 - manages the main alloy pipeline for loki and prometheus
 - manages log rotation for rsyslog to allow adm membership
 - manage service
+- optional: include nagios target for the alloy service (set `ay_manage_nagios`to `true`)
 
 ## Repo Documentation
 
@@ -53,6 +54,8 @@ See the full Puppet documentation including parameters in `docs/index.html`
 
 All dependencies must be included in the catalogue.
 
+- [confdroid_nagios](https://sourcecode.confdroid.com/confdroid/confdroid_nagios) if nagios monitoring is desired
+
 ## Deployment
 
 - native Puppet deployment

manifests/monitoring/target.pp

@@ -8,7 +8,7 @@ class confdroid_alloy::monitoring::target (
 ) inherits confdroid_alloy::params {
   if $ay_manage_nagios == true {
     @@nagios_service { "check_alloy_${fqdn}":
-      check_command       => "check_nrpe!check_alloy!${fn_procs_allowed}!alloy-server",
+      check_command       => "check_nrpe!check_alloy!${ay_procs_allowed}!alloy",
       use                 => 'generic-service',
       host_name           => $fqdn,
       notification_period => '24x7',

manifests/params.pp

@@ -20,6 +20,7 @@
 # @param [Boolean] ay_manage_nagios whether to manage nagios service exports
 # @param [String] ay_target_service the target file for nagios service exports
 # @param [Array] ay_target_contacts the contacts for nagios service exports
+# @param [String] ay_procs_allowed the allowed number of processes for nagios service exports
 # @summary Class contains all parameters for the confdroid_alloy module.
 ##############################################################################
 class confdroid_alloy::params (
@@ -47,8 +48,12 @@ class confdroid_alloy::params (
   Boolean $ay_manage_nagios                   = false,
   String $ay_target_service                   = '/etc/nagios/conf.d/alloy_service.cfg',
   Array $ay_target_contacts                   = ['nagiosadmin'],
+  String $ay_procs_allowed                    = '1:1'
 
 ) {
+  # defaults
+  $fqdn               = $facts['networking']['fqdn']
+
   # service
   $ay_service         = 'alloy'